Handles anon wallet connected publisher case (uplift to 0.71.x) #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
NejcZdovc
previously approved these changes
Sep 16, 2019
NejcZdovc
force-pushed
the
pr3399_connected-update_0.71.x
branch
from
86493c6
to
9cccdf9
Compare
|
@NejcZdovc looks like Can you take a look? |
|
@kjozwiak not important, npm just timeout |
kjozwiak
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. There was a npm timeout when going through CI/Jenkins, but as @NejcZdovc mentioned via #3440 (comment), it wasn't related to this particular PR.
Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #3399
Approved, please ensure that before merging:
After you merge: